Fix incorrect definition of FPSTR() macro and move it from pgmspace.h to WString.h (#1371)#2961
Merged
me-no-dev merged 1 commit intoespressif:masterfrom Jul 17, 2019
Merged
Conversation
Member
|
what have you tested this with? |
Contributor
Author
|
I'm not sure what kind of testing you are looking for, but the following compiles and prints "Hello PROGMEM" on the ESP8266. It fails to compile on the ESP32: #include <pgmspace.h>
// Cannot use F() macro outside of a function, use PROGMEM directly.
static const char HELLO_PROGMEM[] PROGMEM = "Hello PROGMEM";
void printFlashString(const __FlashStringHelper* s) {
Serial.println(s);
}
void setup() {
delay(1000);
Serial.begin(115200);
while(!Serial); // for Arduino Leonardo/Micro
printFlashString(FPSTR(HELLO_PROGMEM));
}
void loop() {
}The error is: |
Contributor
Author
|
If I apply this PR to my ESP32 core on my Arduino IDE 1.8.9 |
Member
|
OK it's not a big deal :) let's merge and see if we get any issues before we cut 1.0.3 final |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.